[Webkit-unassigned] [Bug 61314] [Qt] QtWebKit crashes when dragging not loaded images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61314


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94507|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #6 from Andreas Kling <kling at webkit.org>  2011-05-24 04:30:09 PST ---
(From update of attachment 94507)
View in context: https://bugs.webkit.org/attachment.cgi?id=94507&action=review

Good catch! Needs a test though.

> Source/WebCore/platform/qt/DragImageQt.cpp:70
> -    if (!image)
> -        return 0;
> +    QPixmap* dragImage = 0;
> +    if (image && image->nativeImageForCurrentFrame())
> +        dragImage = new QPixmap(*image->nativeImageForCurrentFrame());
>  
> -    return new QPixmap(*image->nativeImageForCurrentFrame());
> +    return dragImage;

This would read better as:

if (!image || !image->nativeImageForCurrentFrame())
    return 0;
return new QPixmap(*image->nativeImageForCurrentFrame());

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.