[Webkit-unassigned] [Bug 59188] Reftests can not work on Mac build of WebKit.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 10 23:44:29 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=59188
--- Comment #5 from Hayato Ito <hayato at chromium.org> 2011-05-10 23:44:29 PST ---
Thank you for the replay, Dirk.
Okay. I'll take a look further. I suspect DumpRenderTree itself doesn't return image_hash on Mac Port.
(In reply to comment #4)
> (In reply to comment #3)
> > Hi Dirk, Ojan,
> >
> > (In reply to comment #1)
> > > Let me update the status.
> > >
> > > It seems that WebKitDriver.run_test() returns 'None' as an image_hash value when an actual image_hash matches the given driver input's image_hash.
> > > Whereas, ChromiumDriver.run_test() returns an actual image_hash value as is when the actual image_hash matches the given driver input's image_hash.
> >
> > Could you tell me that this difference between WebKitDriver and ChromiumDriver is an expected one?
> >
>
> No, it's a bug. The Driver should always return an image hash if it got one from DRT. Feel free to upload a patch to fix this :)
>
> Seems like pixel tests couldn't possibly work on the Mac port if this was true, but maybe there's something else at play as well. Then again, I haven't tried pixel tests on the Mac port in a long time.
>
> - Dirk
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list