[Webkit-unassigned] [Bug 61802] [Qt][WK2] Add QGLWidget viewport support to MiniBrowser

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61802





--- Comment #5 from Viatcheslav Ostapenko <ostapenko.viatcheslav at nokia.com>  2011-05-31 15:59:18 PST ---
(In reply to comment #4)
> (From update of attachment 95476 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95476&action=review
> 
> r=me
> 
> At some point we should probably make that simply the default...
> 
> > Tools/MiniBrowser/qt/BrowserView.cpp:49
> > +        setViewport(new QGLWidget());
> 
> Nitpick, here you use new GLWidget() and further down just "new QGLWidget"
> 
> > Tools/MiniBrowser/qt/BrowserView.cpp:76
> > +void BrowserView::toggleGLViewport(bool useQGLWidgetViewport)
> > +{
> > +#if defined(QT_CONFIGURED_WITH_OPENGL)
> > +    setViewport(useQGLWidgetViewport ? new QGLWidget : 0);
> > +#endif
> > +}
> 
> setViewport is a public method, so this code doesn't actually have to live in BrowserView but could also be done from the outside.

Ooops! It's already committed.
Should I make those changes as separate patch?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.