[Webkit-unassigned] [Bug 61801] Add Glade catalog for WebKitGTK widgets

Tue May 31 13:48:04 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61801

Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95470|review?                     |review-
               Flag|                            |

--- Comment #2 from Gustavo Noronha (kov) <gns at gnome.org>  2011-05-31 13:48:04 PST ---
(From update of attachment 95470)
Hey, thanks for working on this! I don't know a lot about glade catalogs but I'll try to review this patch. Before I go into details though I'd like to ask you to review the style guide http://www.webkit.org/coding/coding-style.html. The names and declaration locations of variables, the position of the *, the sorting of #include statements, position of bracers are all wrong on the .c file (which, I think should be called webkitglade.c or gladewebkit.c to be consistent with the rest of the files under Sources/WebKit/gtk).

We also need a ChangeLog entry that you can generate with the Tools/Scripts/prepare-ChangeLog  script (use --help to see the relevant options).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.