[Webkit-unassigned] [Bug 56855] [GTK] Provide a way in DRT to check the platform name
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 31 10:45:13 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=56855
Mario Sanchez Prada <msanchez at igalia.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88635|0 |1
is obsolete| |
Attachment #95452| |review?
Flag| |
--- Comment #13 from Mario Sanchez Prada <msanchez at igalia.com> 2011-05-31 10:45:12 PST ---
Created an attachment (id=95452)
--> (https://bugs.webkit.org/attachment.cgi?id=95452&action=review)
Patch proposal
(In reply to comment #12)
> (From update of attachment 88635 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=88635&action=review
>
> You should add a test that shows this is working.
Well I haven't done it since it's a patch for a new functionality in DRT, not in WebKit, so I thought it wouldn't be needed since its functionality would be tested anytime it was used in a LayoutTest :-)
> You should also explain why this is needed.
See comment #8 and comment #10. It's all in there :-)
> > Tools/DumpRenderTree/LayoutTestController.cpp:2093
> > + return JSValueMakeString(context, controller->platformName());
>
> This is leaking the JSStringRef returned by platformName. platformName should return a JSRetainPtr<JSStringRef> instead.
Thanks for the catch. Attaching a new patch fixing these issues.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list