[Webkit-unassigned] [Bug 55481] Consider padding and border when looking for the next/previous line position

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55481





--- Comment #22 from Mario Sanchez Prada <msanchez at igalia.com>  2011-05-31 08:50:26 PST ---
(In reply to comment #20)
> (From update of attachment 95435 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=95435&action=review
> 
> > Source/WebCore/editing/visible_units.cpp:576
> > +        return renderer->positionForPoint(IntPoint(x - absPos.x(), root->selectionTop()));
> 
> This line was last touched by hyatt, reviewed by mitz, as part of bug 20329
> where it was changed from topOverflow() to lineTop().

I'm not sure that is a related issue. The current bug is about being able to "find" the next/previous line for a given VisiblePosition and the fact that the padding and border is currently ignored is causing the trouble, so that's why I think selectionTop/Bottom() are the right way to go. But of course, can't swear on my life :-)

It could be good then, I guess, if mitz and/or hyatt (both already in CC) took a look to it before actually committing the changeset to the repo.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.