[Webkit-unassigned] [Bug 61740] [Texmap][Qt] Enable TextureMapper by default

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61740


Dihan Wickremasuriya <dihan.wickremasuriya at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dihan.wickremasuriya at nokia.
                   |                            |com




--- Comment #11 from Dihan Wickremasuriya <dihan.wickremasuriya at nokia.com>  2011-05-31 08:17:39 PST ---
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > Symbian build is still broken. I have no idea why.
> > 
> > Looks like a problem with the OpenGL headers:
> > 
> >  compile    : Source\WebCore\platform\graphics\opengl\TextureMapperGL.cpp      [armv5_urel.rvct4_0]
> >    "D:/w/qt-symbian-release/build/Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp", line 532: Error:  #20: identifier "GL_BGRA" is undefined
> >          GL_CMD(glTexSubImage2D(GL_TEXTURE_2D, 0, m_dirtyRect.x(), m_dirtyRect.y(), m_dirtyRect.width(), m_dirtyRect.height(), GL_BGRA, GL_UNSIGNED_BYTE, m_buffer->data()))
> >          ^
> > 
> > Should we build without OpenGL on Symbian perhaps?
> 
> This shouldn't even be built on symbian, unless unix|mac applies to Symbian somehow.
> For now we should not enable TextureMapper for symbian, and eventually not build the OpenGL backend for Symbian.

Actually qmake considers Symbian to be a flavor of unix. To exclude the texmap flag for Symbian you'll need to guard it with a 'mac|unix:!symbian' scope.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.