[Webkit-unassigned] [Bug 61771] New: Unnecessary condition checks in HTMLTreeBuilder when not parsing fragment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61771

           Summary: Unnecessary condition checks in HTMLTreeBuilder when
                    not parsing fragment
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P3
         Component: WebCore Misc.
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kbalazs at webkit.org


Let me give an example:
// FIXME: This is slow.
if (!m_tree.openElements()->inTableScope(tbodyTag.localName()) && !m_tree.openElements()->inTableScope(theadTag.localName()) && !m_tree.openElements()->inTableScope(tfootTag.localName())) {
    ASSERT(isParsingFragment());
    parseError(token);
    return;
}

In release builds there is no reason for evaluating the condition if not parsing fragment because it must never be true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.