[Webkit-unassigned] [Bug 61746] [efl] Add ewk API to enable/disable developer extras.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61746


Lucas De Marchi <demarchi at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95370|review+, commit-queue+      |review?, commit-queue?
               Flag|                            |




--- Comment #3 from Lucas De Marchi <demarchi at webkit.org>  2011-05-30 14:23:30 PST ---
(From update of attachment 95370)
View in context: https://bugs.webkit.org/attachment.cgi?id=95370&action=review

Otherwise, looks good

> Source/WebKit/efl/ewk/ewk_view.cpp:2716
> +Eina_Bool ewk_view_setting_enable_developer_extras_set(Evas_Object* o, Eina_Bool enable)
> +{
> +    EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
> +    EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);
> +    if (priv->settings.enable_developer_extras != enable) {

Since this is EAPI and Eina_Bool could assume values other than 1 and 0, a protection is needed for the enable argument. See  ewk_view_setting_enable_scripts_set() as an example.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.