[Webkit-unassigned] [Bug 59318] [GTK] Initial tooltips implementation for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59318


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95334|review?                     |review+
               Flag|                            |




--- Comment #4 from Martin Robinson <mrobinson at webkit.org>  2011-05-30 07:34:37 PST ---
(From update of attachment 95334)
View in context: https://bugs.webkit.org/attachment.cgi?id=95334&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:295
> +    if (keyboardMode) {
> +        notImplemented();
> +        return FALSE;
> +    }

This is for tooltips triggered by keyboard events, right? Is there a bug for this? If so it's probably best to leave the bug link in a comment.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:361
> +    if (tooltip && *tooltip != '\0') {

I think it's clearer to use tooltip[0] here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.