[Webkit-unassigned] [Bug 61725] [GTK] Implement JavaScript dialogs in MiniBrowser

Mon May 30 07:22:05 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61725

Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95332|review?                     |review+
               Flag|                            |

--- Comment #2 from Martin Robinson <mrobinson at webkit.org>  2011-05-30 07:22:05 PST ---
(From update of attachment 95332)
View in context: https://bugs.webkit.org/attachment.cgi?id=95332&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:191
> +    char *buffer = (char *)g_malloc(length * sizeof(char));

You can omit sizeof(char) here. I'm pretty sure it's always one in C. Please put a space after the cast.

> Tools/MiniBrowser/gtk/BrowserWindow.c:460
> +    WKStringRef retval = (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_OK) ? WKStringCreateWithUTF8CString(gtk_entry_get_text(GTK_ENTRY(entry))) : 0;

-> returnValue

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.