[Webkit-unassigned] [Bug 57798] Tiled Backing Store does not regenerate tiles when it should

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57798





--- Comment #11 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2011-05-30 04:28:30 PST ---
(In reply to comment #9)
> Let me disagree with your review.
> First, if the intersection were to be moved into tiledBackingStoreVisibleRect() there would be one intersection for every tiledBackingStore client (currently at least 2: WebCore::Frame and WebKit::QtGraphicsLayerImpl), thus there is no saving in code size, second, the TiledBackingStoreClient interface would be less rich since one would no longer be able to retrieve the size of the visible area of the backing store client, if that would ever be needed for some purpose (such as optimization of tile recreation vs. memory usage) the value returned by tiledBackingStoreVisibleRect would be clipped to contentSize always.

I agree, what about introducing a TiledBackingStore::visibleRect() that would do this logic?
My point is just to avoid duplicate logic since those two hunks need to be synchronized. The reason why an intersection is needed there might not be obvious just by reading the code, it's easier to break.

> Second, It is absolutely essential that the div is green. That is what all the  tests that use this resource test against, this particular test does not even execute the function that resizes the div, because it does not matter for this test. It is true that resizableFrom50%To150%GreenDivOnWhiteBackground.html would be more descriptive, but I tried to stick with a reasonably short name.
> If I remember correctly it is essential that this Div causes the scrollbars to be shown in some of the tests that use it, but for this particular test it only matters that it is green and not red.
> I urge you guys to reconsider this review.

Sure, greendiv is also fine if you prefer it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.