[Webkit-unassigned] [Bug 60539] [GTK] Split libWebCore into two libWebCore and libWebCoreGtk

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60539





--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-05-30 01:01:22 PST ---
(In reply to comment #2)
> (From update of attachment 92930 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=92930&action=review
> 
> This looks fine to me, but I'd like to get Xan and Kov to look at this one as well.
> 
> > Source/WebCore/GNUmakefile.am:762
> > +libWebCoreGtk_la_CPPFLAGS = \
> > +	-DBUILDING_WEBKIT \
> > +	$(global_cppflags) \
> 
> Would it make sense to remove GTK_CLFAGS here?

global_cppflags contains some flags for GTK (deprecation guards, etc.), but I think it doesn't contain GTK_CFLAGS. Anyway, as long as it doesn't link to GTK, it's not a problem.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.