[Webkit-unassigned] [Bug 61603] FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61603


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95252|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #16 from Nikolas Zimmermann <zimmermann at kde.org>  2011-05-28 00:46:08 PST ---
(From update of attachment 95252)
View in context: https://bugs.webkit.org/attachment.cgi?id=95252&action=review

r-, because of a test issue, but it's easy to fix:

> LayoutTests/svg/filters/feConvolveFilter-y-bounds.svg:7
> +

Patch looks almost perfect, though I'd love to have a comment here stating how the result should look like.

Even better, you'd maybe include a blue <line> and a green <rect> below, that looks the same, and add a comment "Both shapes should look identical" (but only in the file as comment, not as <text> element, to get a cross-platform pixel test result, if possible).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.