[Webkit-unassigned] [Bug 61260] [Chromium]Call setToolTipText() in WebPopupMenuImpl mouse move handler to show tool tip in select popup window.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61260





--- Comment #15 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-05-27 11:24:00 PST ---
(In reply to comment #14)
> Thank you for your review, fishd.
> 
> Here is the chromium side patch,
> http://codereview.chromium.org/6974007/
> If you have time, could you review it too?
> 
> Also we need to commit this patch at the same time with chromium and webkit.
> How I can commit them at the same time?

It is really necessary in this case?  It looks like render_view.cc should still compile and work properly if only this WebKit change lands.  If I'm wrong, then what we sometimes do is add a #define to a WebKit API header.  Then, we land a Chromium patch that is conditional on that #define to implement either the old API or the new API.  So land that Chromium patch first.  Then land the WebKit patch.  Then land a Chromium patch to clean out the conditional code.  Then go back and land another WebKit patch to remove the #define.  Lot's of back-n-forth, but it is fairly easy once you get used to it.  Not sure it is necessary in this case though.


> BTW, I cannot find you e-mail address, fishd at chromium.org in Chromium CL.
> Do you have another e-mail?

Use darin at chromium.org.  Sorry for the confusion.  I only use the fishd alias on WebKit to avoid confusion with Darin Adler.  Bugzilla has a habit of only showing usernames, dropping the @domain part :-P

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.