[Webkit-unassigned] [Bug 54826] [GTK] Add a setting to change the pixels per line used for scrolling

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54826


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92395|review?                     |review-
               Flag|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-05-27 10:37:57 PST ---
(From update of attachment 92395)
View in context: https://bugs.webkit.org/attachment.cgi?id=92395&action=review

> Source/WebCore/platform/gtk/PlatformWheelEventGtk.cpp:75
> -    // FIXME: retrieve the user setting for the number of lines to scroll on each wheel event
> -    m_deltaX *= static_cast<float>(Scrollbar::pixelsPerLineStep());
> -    m_deltaY *= static_cast<float>(Scrollbar::pixelsPerLineStep());
> +    Settings* settings = Settings::globalSettings();
> +    m_deltaX *= settings->scrollPixelCount();
> +    m_deltaY *= settings->scrollPixelCount();

I think this comment actually refers to retrieving the setting from GTK+.  I do not think it is worth exposing this kind of low-level option through the API. If there is a default GTK+ value for this though, we should be sure to use it so that scrollbars move in a more native way.

Personally I do not find anything wrong with the current scrollbar behavior and feel we can probably just remove the comments and close the bug. I could be wrong though and perhaps our scrollbars could move more natively during wheel events.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.