[Webkit-unassigned] [Bug 61013] Keep linked images in the accessibility tree.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61013


chris fleizach <cfleizach at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94712|review?                     |review-
               Flag|                            |




--- Comment #4 from chris fleizach <cfleizach at apple.com>  2011-05-27 09:22:03 PST ---
(From update of attachment 94712)
View in context: https://bugs.webkit.org/attachment.cgi?id=94712&action=review

> Source/WebCore/ChangeLog:10
> +

I may be dense, but this comment doesn't make sense to me. 
Are you saying... "don't expose the src of the link.... and to do that, you override the image src?"
a) I don't understand why you don't want to expose the source of the link.
b) I don't understand why you want to change what the URL is for the image. Right now it should be the the location of the image. That seems correct in my mind, because the src of the link is returned in the link

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1872
>                  return true;

this seems like it alters the informal standard that's pretty clear. if alt is empty, image should be ignored

> LayoutTests/accessibility/tree-contains-linked-images.html:24
> +     }

this layout test doesn't seem to test the altered behavior. this <img> was not ignored previously because it had an alt tag.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.