[Webkit-unassigned] [Bug 60563] [Chromium]Click event is not fired for a menulist <select>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=60563





--- Comment #43 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-05-27 09:10:46 PST ---
(From update of attachment 95112)
View in context: https://bugs.webkit.org/attachment.cgi?id=95112&action=review

ok with nits, if Jay confirms this can't be tested using unit testing framework.

> Source/WebCore/ChangeLog:5
> +        [Chromium]Click event is not fired for a menulist <select>

Need a space between [Chromium] and Click.

> Source/WebCore/ChangeLog:8
> +        Manual test with select-element-mouse-event.html.

Manual test: select-element-mouse-event.html

> Source/WebCore/manual-tests/select-element-mouse-event.html:19
> +  alert('down');

Please don't use alerts. Log into the page itself. That's a lot less intrusive.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:684
> +    // Clear m_fcosuedNode here, because we cannot clear in hidePopup() which is called before dispatchMouseEvent() is called.

typo: m_focusedNode.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.