[Webkit-unassigned] [Bug 61205] Web Inspector: Cache XHR content in backend, do not use initialContentSet for XHRs.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61205





--- Comment #12 from Vsevolod Vlasov <vsevik at chromium.org>  2011-05-27 05:01:32 PST ---
(In reply to comment #10)
> (From update of attachment 94770 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=94770&action=review
> 
> > Source/WebCore/inspector/InspectorResourceAgent.h:61
> >  class EventsCollector;
> 
> Please move EventsCollector up to keep alphabetic order.
Done.

> > Source/WebCore/inspector/InspectorResourceAgent.h:124
> > +    NetworkResourcesData* resourcesData() { return m_resourcesData.get(); }
> 
> resourcesData() is not used outside InspectorResourceAgent, so it should be private or inlined.
Inlined.

> > Source/WebCore/inspector/NetworkResourcesData.cpp:94
> > +        resourceData->content.append(content);
> 
> It may occur that ensureFreeSpace has just removed resourceData from m_resourceDataDeque and reset its accumulated content in which case the content here will be corrupted.
Fixed.

> > Source/WebCore/inspector/NetworkResourcesData.h:34
> > +#include <wtf/text/StringHash.h>
> 
> Remove this include?
Changed to WTFString.h

> > Source/WebCore/inspector/NetworkResourcesData.h:68
> > +    ~NetworkResourcesData() { }
> 
> style: please move destructor to the next line after the constructor. 
Done.

> Also, you should delete all values in the destructor. r- for this.
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.