[Webkit-unassigned] [Bug 61603] FEConcolveMatrix::getPixelValue() is range checking x against height, instead of y, when determining if a pixel is in bounds

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61603





--- Comment #13 from Nikolas Zimmermann <zimmermann at kde.org>  2011-05-27 02:43:34 PST ---
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #9)
> > >   Reviewing diff to determine which lines changed.
> > > svn: '../../Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp' is not a working copy
> > > svn: '../../Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp' does not exist
> > ^^^ Totally overlooked this before, your checkout seems broken.
> > You should try fixing this up (what does svn st say in Source/WebCore/platform/graphics/filters?) or re-checkout.
> 
> Ryan-Sleevis-Mac-mini:filters Ryan$ svn st
> M       FEConvolveMatrix.cpp
> 
> From the top-level WK dir (note, reverted ChangeLog to try to figure out what is up)
> Ryan-Sleevis-Mac-mini:WebKit Ryan$ svn st
> ?       Source/WebKit/chromium/WebKit.xcodeproj
> ?       Source/WebCore/WebCore.gyp/idls_list_temp_file.tmp
> M       Source/WebCore/platform/graphics/filters/FEConvolveMatrix.cpp
> ?       Source/ThirdParty/glu/glu.xcodeproj
> ?       LayoutTests/platform/chromium-mac/svg/filters/feConvolveFilter-bounds-expected.txt
> ?       LayoutTests/platform/chromium-mac/svg/filters/feConvolveFilter-bounds-expected.png
> A       LayoutTests/svg/filters/feConvolveFilter-bounds.svg

I'm still not sure why prepare-ChangeLog tries to lookup "../../Source/WebCore" if you invoke it right from the top level webkit checkout directory, it should look at "Source/WebCore" instead, hmm.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.