[Webkit-unassigned] [Bug 59693] [Feature Request] Need SpellCheck API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=59693





--- Comment #10 from MORITA Hajime <morrita at google.com>  2011-05-26 22:43:29 PST ---
(From update of attachment 94961)
View in context: https://bugs.webkit.org/attachment.cgi?id=94961&action=review

Hi Bono-san, thank you for update.
You can add Skipped entries where other editing or spelling test is listed.
It would reduce the chance of conflict.

> Source/WebCore/dom/DocumentMarkerController.cpp:677
> +        DocumentMarker marker = list->at(i);

Could you use const refrence if possible? It will save an extra copy.

> Source/WebCore/dom/DocumentMarkerController.cpp:683
> +        result->append(SpellcheckRange::create(marker.startOffset(), marker.endOffset() - marker.startOffset(), suggestions.release(), 0));

Could you add length() to DocumentMarker for here? It would be illustrative.

> Source/WebCore/html/HTMLDivElement.idl:27
> +        void addSpellcheckRange(in unsigned long start, in unsigned long length, in [Optional] DOMStringList suggestions, in [Optional] unsigned short options);

Don't we throw any exceptions? It might be a question about the spec though.

> LayoutTests/ChangeLog:6
> +        https://bugs.webkit.org/show_bug.cgi?id=59693

Can we have a test pixel test for that to ensure that the user-marker is actually visible?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.