[Webkit-unassigned] [Bug 61601] Implement CSSPropertyOutlineStyle handler in CSSStyleApplyProperty

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61601





--- Comment #3 from Luke Macpherson <macpherson at chromium.org>  2011-05-26 22:08:24 PST ---
Yeah, it's an odd patch. Let me explain. The motivation was not to eliminate the bool.
It's an odd situation because of the way outline style is defined as an outline of border style.
This leads to a situation where RenderStyle::setOutlineStyle is the only setter on RenderStyle to take two parameters, which means that it doesn't fit the ApplyPropertyDefault pattern in CSSStyleApplyProperty very well. Splitting it up into two separate setters makes it fit that pattern a lot more cleanly, and avoids defining a new ApplyProperty class just for outline-style.

So that's the rationale behing the change. I'm also not completely convinced it's the right way to go - it seems like a special case either way.

Another alternative might be to stop defining OutLineValue in terms of BorderValue and EBorderStyle.

Let me know what you think, I'd love a second opinion, especially if there is an obviously better approach that I haven't considered.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.