[Webkit-unassigned] [Bug 61600] New: SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61600

           Summary: SVGRadialGradientElement::selfHasRelativeLengths()
                    doesn't consider if cx() is relative
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: SVG
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: rsleevi at chromium.org
                CC: zimmermann at kde.org


This was reported downstream in Chromium by a user running a static analyzer over the Chromium sources, which include WebKit.

The text of the original report (from PVS studio) is:

V501 There are identical sub-expressions 'cy ().isRelative ()' to the left and to the right of the '||' operator. webcore_svg svgradialgradientelement.cpp 253

bool SVGRadialGradientElement::selfHasRelativeLengths() const
{
  return cy().isRelative()
      || cy().isRelative()
      || r().isRelative()
      || fx().isRelative()
      || fy().isRelative();
}

The logic error is that cy().isRelative() is checked twice, rather than checking cx() and then cy()

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.