[Webkit-unassigned] [Bug 61495] Make RenderStyle visuallyOrdered property use an enum instead of a bool.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 26 17:41:59 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=61495





--- Comment #6 from Luke Macpherson <macpherson at chromium.org>  2011-05-26 17:41:59 PST ---
(From update of attachment 94909)
View in context: https://bugs.webkit.org/attachment.cgi?id=94909&action=review

>> Source/WebCore/css/CSSPrimitiveValueMappings.h:2592
>> +        return LogicalOrder;
> 
> Don't add a default: so that teh compiler will complain if you forget an enum.  You can always do the "default" behavior after the switch.

You need it here - m_value.ident has hundreds of possible values - it is the superset of all css values.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list