[Webkit-unassigned] [Bug 60964] Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu May 26 16:23:54 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=60964


Dirk Pranke <dpranke at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dpranke at chromium.org,
                   |                            |mihaip at chromium.org,
                   |                            |ojan at chromium.org,
                   |                            |tony at chromium.org




--- Comment #3 from Dirk Pranke <dpranke at chromium.org>  2011-05-26 16:23:54 PST ---
I'm probably not the right person to review this, since my javascript-fu is pretty weak. However, it looks like this code will assume we're only ever writing one metric into the JSON file from a given run (and hence can only sort on one column).

Does it make more sense to modify this so that we can handle N different sortable metrics? I don't really know what you have in mind so if it's easier to just start with one metric, that's fine too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list