[Webkit-unassigned] [Bug 57148] Delete table in contentEditable/designMode produces odd contents

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=57148


Annie Sullivan <sullivan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #95025|1                           |0
        is obsolete|                            |




--- Comment #27 from Annie Sullivan <sullivan at chromium.org>  2011-05-26 14:25:55 PST ---
(From update of attachment 95025)
View in context: https://bugs.webkit.org/attachment.cgi?id=95025&action=review

>> LayoutTests/editing/deleting/delete-last-char-in-table-expected.txt:6
>> +execDeleteCommand: <br>
> 
> Maybe it's clear when this test passes from this output.  Can you add a some check?  e.g. by checking document.getElementsByTagName('span').length == 0.

I did this by adding a result element. I see this done in a couple different ways in existing tests (e.g. some use document.write()), so please let me know if there is a preferred way to do this.

>> LayoutTests/editing/deleting/delete-last-char-in-table.html:5
>> +<p>When deleteing the last character in a table deletes the table, no styled spans should be left behind. To test manually, place cursor after "X" and do a backward delete. No styled span should be created.</p>
> 
> I would combine these two paragraphs.

Done. I added a line break because the text got really long.

>> Source/WebCore/editing/EditingStyle.cpp:-54
>> -    CSSPropertyBorderCollapse,
> 
> We need a test for this.  r- due to the lack of test for border-collapse.

I added a border-collapse style to the delete-last-char-in-table test. It fails on TOT and passes after my change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.