[Webkit-unassigned] [Bug 61536] [Chromium] Add missing compile guards for WebWorkers in WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61536





--- Comment #4 from David Levin <levin at chromium.org>  2011-05-26 11:49:13 PST ---
(From update of attachment 94992)
View in context: https://bugs.webkit.org/attachment.cgi?id=94992&action=review

>>> Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp:96
>>> +    m_callbacks->didOpenFileSystem(name, AsyncFileSystemChromium::create(m_type, path));
>> 
>> This duplicates a line of code... By placing #if/#endif around if/else, it's possible to avoid that.
> 
> Yes, but it may introduce style errors in the bots that don't enable workers. If you think this is ok I'll be happy to fix it like you propose.

This could do 

OwnPtr<WebFileSystemCallbacksImpl> callbacks(this);

#if
if (m_context && m_context->isWorkerContext()) {
       m_callbacks->didOpenFileSystem(name, WorkerAsyncFileSystemChromium::create(m_context, m_type, path, m_synchronous));
   return;
}
#endif
m_callbacks->didOpenFileSystem(name, AsyncFileSystemChromium::create(m_type, path));

which addresses both issues.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.