[Webkit-unassigned] [Bug 61536] [Chromium] Add missing compile guards for WebWorkers in WebKit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61536


Dmitry Titov <dimich at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94992|review?                     |review-
               Flag|                            |




--- Comment #2 from Dmitry Titov <dimich at chromium.org>  2011-05-26 11:22:30 PST ---
(From update of attachment 94992)
View in context: https://bugs.webkit.org/attachment.cgi?id=94992&action=review

Great! Couple of comments, lets do another iteration:

> Source/WebKit/chromium/src/DatabaseObserver.cpp:71
> +        return false;

Lets add ASSERT_NOT_REACHED() here, to document that we don't expect any other case but Document in this case.

> Source/WebKit/chromium/src/LocalFileSystemChromium.cpp:101
> +        allowed = false;

Same as above, ASSERT_NOT_REACHED() could be useful here.

> Source/WebKit/chromium/src/WebFileSystemCallbacksImpl.cpp:96
> +    m_callbacks->didOpenFileSystem(name, AsyncFileSystemChromium::create(m_type, path));

This duplicates a line of code... By placing #if/#endif around if/else, it's possible to avoid that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.