[Webkit-unassigned] [Bug 50245] Add word-prefix search options to the text search without ICU

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=50245





--- Comment #2 from Chang Shu <cshu at webkit.org>  2011-05-26 11:12:21 PST ---
(From update of attachment 95002)
View in context: https://bugs.webkit.org/attachment.cgi?id=95002&action=review

I understand you didn't unskip findString.html because of the Thai char issue. But it will be good to show some tests improvement after your fix. Maybe we can split findString.html and put Thai tests in a separate test?
Overall, it's a good patch. Thanks.

> Source/WebCore/editing/TextIterator.cpp:106
> +    bool isWordStartMatch(size_t, size_t length) const;

What do you think we move all the common apis to the common place?

> Source/WebCore/editing/TextIterator.cpp:2189
> +

same thing here. We can move identical code to the common place.

> Source/WebCore/editing/TextIterator.cpp:2236
> +            memcpy(m_context.data(), m_context.data() + 1, (m_context.size() - 1) * sizeof(UChar));

memcpy to overlapped place may cause unexpected results?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.