[Webkit-unassigned] [Bug 61160] GTK: media/video-src-invalid-poster.html Failed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61160





--- Comment #5 from Philippe Normand <pnormand at igalia.com>  2011-05-26 09:45:42 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #0)
> > > On GTK, the media/video-src-invalid-ponter.html test gives the correct width but the wrong height.
> > 
> > Are you sure? What I saw locally is that sometimes the test times out, otherwise it succeeds locally.
> 
> Definitely.  Check the test results from the URL field above.  It shows the video sized to 73 (correct) by 150 (incorrect, but probably the default video element width).
> 

Oh I didn't that link indeed. Yes it's odd. I recall the Release bot might need a GStreamer upgrade to be in par with the Debug bots.
At least locally the test passes but I use a fairly recent GStreamer version.

> However, if it's not reproducing any longer, then aces. ;)
> 
> > Hence the attached patch to avoid the timeout
> 
> So the patch seems to significantly change the behavior of the test by calling |video.load()|.  Shouldn't we see the correct behavior without calling load()?  The original test gave the video element a whole second to resize and display the poster.  Is that not enough time?

On my slow laptop I could see the timeout happen. The GTK bots are know to not be lighning fast either...
In general for media tests (at least) I believe we should react more on events instead of waiting on something to happen before a XXXX ms timeout to fire.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.