[Webkit-unassigned] [Bug 58886] Web Inspector: Render non-document HTML resources as HTML

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58886





--- Comment #9 from Vsevolod Vlasov <vsevik at chromium.org>  2011-05-26 08:38:04 PST ---
(In reply to comment #8)
> (From update of attachment 90351 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=90351&action=review
> 
> > Source/WebCore/inspector/front-end/NetworkItemView.js:48
> > +        var responseView = new WebInspector.ResourceSourceFrame(resource);
> 
> You could reuse existing SourceFrame in case previewView is instance of ResourceSourceFrame. In fact, you should adjust resourceViewForResource to cache only SourceFrame views.
We ar enot caching SourceFrames anymore, but I reuse SourceFrame for the response and rpeview view the same resource.

> > Source/WebCore/inspector/front-end/Resource.js:795
> > +            if (data == null)
> 
> pending callbacks should be notified upon missing content.
Removed that.

> > Source/WebCore/inspector/front-end/ResourceHTMLView.js:52
> > +        this.element.textContent = "";
> 
> this.element.removeChildren()
Done.

> > Source/WebCore/inspector/front-end/ResourceView.js:49
> > +        return new WebInspector.ResourceHTMLView(resource);
> 
> Reuse SourceFrame-based views when possible as per comment above.
Reusing SourceFrame between preview and response view now.

> > Source/WebCore/inspector/front-end/ResourceView.js:80
> > +        if (WebInspector.ResourceJSONView.parseJSON(resource.content))
> 
> This seems to be a bit too expensive. Testing for the prototype would be sufficient.
This method was removed, so this is not needed anymore.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.