[Webkit-unassigned] [Bug 61495] Make RenderStyle visuallyOrdered property use an enum instead of a bool.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61495





--- Comment #4 from Eric Seidel <eric at webkit.org>  2011-05-26 06:26:19 PST ---
(From update of attachment 94909)
View in context: https://bugs.webkit.org/attachment.cgi?id=94909&action=review

> Source/WebCore/css/CSSPrimitiveValueMappings.h:2592
> +    default:
> +        ASSERT_NOT_REACHED();
> +        return LogicalOrder;

Don't add a default: so that teh compiler will complain if you forget an enum.  You can always do the "default" behavior after the switch.

> Source/WebCore/rendering/style/RenderStyleConstants.h:431
> +enum ERtlOrdering { LogicalOrder = 0, VisualOrder };

RTL is generally all caps.  So this would be ERTLOrdering.  But I would just drop the E personally. :)  Does this only apply to RTL?  I guess for RTL logical and visual ordering are the same so we don't care?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.