[Webkit-unassigned] [Bug 61496] [EFL] Add javascript_can_open_window API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61496





--- Comment #9 from Lucas De Marchi <demarchi at webkit.org>  2011-05-26 05:25:29 PST ---
(In reply to comment #8)
> (In reply to comment #7)
> > (From update of attachment 94912 [details] [details])
> > Humn... I'm almost sure I implemented this ~ 1 year ago. Could you check if what you need is not what was done in r61706? I remember I was sending a signal to browser which could allow or deny the creation of a new window.
> 
> I think this patch is a little different from r61706. This patch prohibits that new window creation signal by javascript is not sent to ewk layer. But, it seems r61706 has similar feature.
> 

Is the net effect the same? I.e.: is blocking the signal any better than waiting for browser to allow or deny the window creation?


> If this patch is landed, I think there is no problem. But, this patch is a little duplicate with r61706.
> 
> Does you think this patch doesn't need to land ?

I think we shouldn't have duplicate features, but I'm ok if there's a reason to block the signal instead of waiting for the signal.

I remember that the signal treats the case with 'target="_blank"' too, so it seems to support more use cases. Is there any use case that your approach supports that is not supported by the current implementation?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.