[Webkit-unassigned] [Bug 61515] New: [Chromium] fix a layout test crash except for mac (LayoutTest/fast/forms/select-script-onchange.html)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61515

           Summary: [Chromium] fix a layout test crash except for mac
                    (LayoutTest/fast/forms/select-script-onchange.html)
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: toyoshim at chromium.org


LayoutTest/fast/forms/select-script-onchange.html crashes on chromium-linux and chromium-win.

Pop-up keystrokes depends on platform and classed into two groups.
As WebCore/dom/SelectElement.cpp said like:

// Configure platform-specific behavior when focused pop-up receives arrow/space/return keystroke.
// (PLATFORM(MAC) and PLATFORM(GTK) are always false in Chromium, hence the extra tests.)
#if PLATFORM(MAC) || (PLATFORM(CHROMIUM) && OS(DARWIN))
#define ARROW_KEYS_POP_MENU 1
#define SPACE_OR_RETURN_POP_MENU 0
#elif PLATFORM(GTK) || (PLATFORM(CHROMIUM) && OS(UNIX))
#define ARROW_KEYS_POP_MENU 0
#define SPACE_OR_RETURN_POP_MENU 1
#else
#define ARROW_KEYS_POP_MENU 0
#define SPACE_OR_RETURN_POP_MENU 0
#endif

This test sends "t\r" keyDown event to change the selected item.
It cause calling WebViewHost::createPopupMenu() on SPACE_OR_RETURN_POP_MENU platform,
and it's not implemented by DumpRenderTree for chromium
(Tools/DumpRenderTree/chromium/WebViewHost.cpp:241).

Originally "\r" must be intended to call htmlForm->submitImplicitly() on ARROW_KEYS_POP_MENU platform.
But this function isn't called on SPACE_OR_RETURN_POP_MENU platform.
So, I just skip it on SPACE_OR_RETURN_POP_MENU platform.

Crash dump is following
[11297:11297:4333840847280:ERROR:process_util_posix.cc(108)] Received signal 11
        base::debug::StackTrace::StackTrace() [0x91b81a]
        base::(anonymous namespace)::StackDumpSignalHandler() [0x8e42cb]
        0x7f8ebbed3af0
        WebKit::WebPopupMenuImpl::Init() [0x4fbb82]
        WebKit::ChromeClientImpl::popupOpened() [0x4be183]
        WebCore::PopupContainer::showPopup() [0xd6cf6d]
        WebCore::PopupContainer::showInRect() [0xd6d98c]
        WebCore::PopupMenuChromium::show() [0xd71993]
        WebCore::RenderMenuList::showPopup() [0x159fbb2]
        WebCore::SelectElement::menuListDefaultEventHandler() [0x10a0a3b]
        WebCore::SelectElement::defaultEventHandler() [0x10a1a9c]
        WebCore::HTMLSelectElement::defaultEventHandler() [0x675866]
        WebCore::EventDispatcher::dispatchEvent() [0x1046f51]
        WebCore::EventDispatchMediator::dispatchEvent() [0x104572c]
        WebCore::KeyboardEventDispatchMediator::dispatchEvent() [0x1054729]
        WebCore::EventDispatcher::dispatchEvent() [0x10458dd]
        WebCore::Node::dispatchKeyEvent() [0x106819f]
        WebCore::EventHandler::keyEvent() [0x126ba76]
        WebKit::WebViewImpl::charEvent() [0x4a8a5f]
        WebKit::WebViewImpl::handleInputEvent() [0x4aa330]
        EventSender::keyDown() [0x43083d]
(snip)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.