[Webkit-unassigned] [Bug 61287] [UNIX] Don't use SOCK_DGRAM in socketpair()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61287





--- Comment #16 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-05-26 02:26:11 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > Created an attachment (id=94943)
 --> (https://bugs.webkit.org/attachment.cgi?id=94943&action=review) [details] [details]
> > New patch using SOCK_SEQPACKET when available
> > 
> > Actually, I think falling back to STREAM sockets is much easier than using a dummy socket, because we can use the same code for both STREAM and SEQPACKET 
> 
> 
> No you cannot, if you don't modify the current code.
> 
> If you do modify the current code, as with this patch, then you don't accept the point about redundant complexity and possible regressions the patch causes.

If it's matter of code complexity, I don't think this patch is that different than current code though, wouldn't it be better to split this again and use QSocket/GSocket?, Using GSocket this code would be just a few lines, and I guess it would be the same for Qt.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.