[Webkit-unassigned] [Bug 61324] --webkit-visual-word does not work well in words separated by multiple spaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61324





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2011-05-25 18:57:59 PST ---
(From update of attachment 94867)
View in context: https://bugs.webkit.org/attachment.cgi?id=94867&action=review

> Source/WebCore/ChangeLog:10
> +        the one at left or right of current position. It will have a performance hit. 

By will have a performance hit, do you mean that we'll have a performance regression?

> Source/WebCore/editing/visible_units.cpp:1534
>      if (box->direction() == blockDirection) {
> -        if (blockDirection == RTL)
> -            wordBreak = positionBeforeNextWord(visiblePosition);
> -        else
> +        if (blockDirection == LTR)
>              wordBreak = previousWordPosition(visiblePosition);
>      } else {
> -        if (blockDirection == RTL)
> -            wordBreak = positionAfterPreviousWord(visiblePosition);
> -        else
> +        if (blockDirection == LTR)
>              wordBreak = nextWordPosition(visiblePosition);
>      }

I would put if (box->direction() == blockDirection) .. else .. in if (blockDirection == LTR) instead.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.