[Webkit-unassigned] [Bug 49468] [Qt] Assertion failure in DocumentLoader::commitData when loading a media document

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49468





--- Comment #12 from Simon Hausmann <hausmann at webkit.org>  2011-05-25 17:01:24 PST ---
(From update of attachment 94838)
View in context: https://bugs.webkit.org/attachment.cgi?id=94838&action=review

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:930
> +            // When Plugins and Error handling are enabled, the cancel operation
> +            // may put a duplicate item on the history stack. This only happens
> +            // on certain configurations.
> +            if (currentItemBeforeCancel && currentItemAfterCancel
> +                && currentItemBeforeCancel != currentItemAfterCancel
> +                && currentItemBeforeCancel->originalURL() == currentItemAfterCancel->originalURL()) {
> +                // There are 2 duplicate items on top of stack. Pop the top one.
> +                page->backForward()->setCurrentItem(currentItemBeforeCancel);

This doesn't seem right. Why do only we need this but not the other ports?

I suggest to do a build of another port (Gtk for example) and try to see where the history item is cleared in the other ports. Note that http://trac.webkit.org/changeset/51104 also changes shouldFallBack(). Either way I think we should forward-port 51104 to WebKit/qt.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.