[Webkit-unassigned] [Bug 61407] QuickLooks quirk is expensive to calculate

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61407


Brady Eidson <beidson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94748|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Brady Eidson <beidson at apple.com>  2011-05-25 14:22:47 PST ---
(From update of attachment 94748)
View in context: https://bugs.webkit.org/attachment.cgi?id=94748&action=review

r+ with the following changes:

> Source/WebCore/loader/FrameLoader.cpp:2416
> +    if (request.cachePolicy() == ReloadIgnoringCacheData && ResourceRequest::useQuickLookResourceCachingQuirks() && !equalIgnoringCase(request.httpMethod(), "post"))

You can put the !equalIgnoringCase(request.httpMethod(), "post") before the useQuickLookResourceCachingQuirks() for an even more "less likely to calculate the quicklooks quirks" setup.

> Source/WebCore/platform/network/mac/ResourceRequestMac.mm:182
> +    const char* bundleID = [[[NSBundle mainBundle] bundleIdentifier] UTF8String];
> +    if (bundleID && !strcasecmp(bundleID, "com.apple.Safari"))
> +        return false;

You should use applicationIsSafari() in RuntimeApplicationChecks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.