[Webkit-unassigned] [Bug 56981] CSSStyleSheet#insertRule doesn't work well with imported stylesheets

Wed May 25 11:49:19 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=56981

--- Comment #5 from Julien Chaffraix <jchaffraix at webkit.org>  2011-05-25 11:49:18 PST ---
(From update of attachment 94035)
View in context: https://bugs.webkit.org/attachment.cgi?id=94035&action=review

>> LayoutTests/fast/css/import-and-insert-rule-no-update.html:1
>> +<!DOCTYPE HTML>
> 
> html is usually lowercase

Sure, thought it should not impact the document mode.

>> LayoutTests/fast/css/import-and-insert-rule-no-update.html:3
>> +<meta http-equiv="content-type" content="text/html; charset=UTF-8">
> 
> Remove this line.

Done.

>> LayoutTests/fast/css/import-and-insert-rule-no-update.html:8
>> +<div id="testArea"> </div>
> 
> Remove space

Done.

>> LayoutTests/fast/css/import-and-insert-rule-no-update.html:33
>> +    window.setTimeout(test, 100);
> 
> This will be prone to flakiness. Is there some other way to test when the stylesheet has loaded? Maybe poll for the computed style of some other element?

Good catch, we could do a certain number of retries to leave enough room for the stylesheet to load. The current problem is that the new stylesheet is not applied thus we could poll forever. I don't see a reliable way to get the 'stylesheet loaded' information but we can mitigate the flakiness. Let me know what you think of that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.