[Webkit-unassigned] [Bug 61416] [JSC] malfunction during arithmetic condition check with negative number (-2147483648)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61416





--- Comment #3 from hojong.han at samsung.com  2011-05-25 03:36:26 PST ---
(From update of attachment 94754)
>Index: Source/JavaScriptCore/ChangeLog
>===================================================================
>--- Source/JavaScriptCore/ChangeLog	(revision 87279)
>+++ Source/JavaScriptCore/ChangeLog	(working copy)
>@@ -1,3 +1,13 @@
>+2011-05-25  Hojong Han  <hojong.han at samsung.com>
>+
>+        Reviewed by NOBODY (OOPS!).
>+
>+        Adding the condition to check 0x80000000 when making ARM instruction CMN for JIT.
>+        https://bugs.webkit.org/show_bug.cgi?id=61416
>+
>+        * assembler/MacroAssemblerARM.h:
>+        (JSC::MacroAssemblerARM::branch32):
>+
> 2011-05-24  Keishi Hattori  <keishi at webkit.org>
> 
>         Reviewed by Kent Tamura.
>Index: Source/JavaScriptCore/assembler/MacroAssemblerARM.h
>===================================================================
>--- Source/JavaScriptCore/assembler/MacroAssemblerARM.h	(revision 87276)
>+++ Source/JavaScriptCore/assembler/MacroAssemblerARM.h	(working copy)
>@@ -416,7 +416,7 @@
>             m_assembler.ldr_un_imm(ARMRegisters::S0, right.m_value);
>             m_assembler.cmp_r(left, ARMRegisters::S0);
>         } else {
>-            ARMWord tmp = m_assembler.getOp2(-right.m_value);
>+            ARMWord tmp = (right.m_value == 0x80000000)?ARMAssembler::INVALID_IMM:m_assembler.getOp2(-right.m_value);
>             if (tmp != ARMAssembler::INVALID_IMM)
>                 m_assembler.cmn_r(left, tmp);
>             else

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.