[Webkit-unassigned] [Bug 58027] Avoid leaking document when leaving google.com due to geolocation permission request

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=58027





--- Comment #8 from John Knottenbelt <jknotten at chromium.org>  2011-05-25 03:18:22 PST ---
(From update of attachment 88606)
View in context: https://bugs.webkit.org/attachment.cgi?id=88606&action=review

A test to count the number of notifiers left in the lists after page reload should be possible. However, exposing this count seems only useful for this particular test case. Is there a way to add this test without complicating the interfaces of the Geolocation, GeolocationController, GeolocationClient and embedder-specific client classes?

>>> Source/WebCore/page/Geolocation.cpp:342
>>> +    m_requestsAwaitingCachedPosition.remove(notifier);
>> 
>> I think that the only way for a notifier to be in this list when it encounters a fatal error is when Geolocation::reset() is called. Is this what you're protecting against?
> 
> I added this one for completions sake. It can be left out.

Steve: Yes, we can get a build up of notifiers in this case, since the main Frame (and therefore Geolocation instance) is reused across page reloads.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.