[Webkit-unassigned] [Bug 61350] [CMAKE] Split JSC related files from WebCore/CMakeLists.txt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61350





--- Comment #5 from Patrick R. Gansterer <paroga at paroga.com>  2011-05-24 23:50:56 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > It looks mostly OK to me too. Should the platform-specific ScriptController${PLATFORM}.cpp files still be included in WebCore/CMakeLists{Efl,WinCE}.cmake?
> 
> It looks reasonable to me,
> but WinCE use ScriptControllerWin.cpp.
> 
> Patrick, can we clone or rename ScriptControllerWin.cpp to ScriptControllerWinCE.cpp?

Don't WinApple and WinCairo use this file too?
I don't think this is a good idea. IMHO using ${PLATFORM} for filenames and directories is a very bad idea, because different platforms share different code. An example where we have this problem already is http://trac.webkit.org/browser/trunk/Source/WebKit/CMakeLists.txt?rev=83792#L65. When I Create a WinApple, WinCairo and WinGDI port, all of them use the win-directory, but have different implementations of GraphicsCntext, NetworkInterface and so on.
I'd like to keep adding of _all_ the platform specific files in different files.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.