[Webkit-unassigned] [Bug 61332] Convert LayoutTests/editing/deleting/5206311-2.html to dump-as-markup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61332





--- Comment #7 from Annie Sullivan <sullivan at chromium.org>  2011-05-24 14:40:22 PST ---
(From update of attachment 94668)
View in context: https://bugs.webkit.org/attachment.cgi?id=94668&action=review

> LayoutTests/editing/deleting/5206311-2.html:5
>  function runTest(num)

I changed this to take an element and use getElementsByClassName() to find the root, description, start and end. Hopefully it's a little cleaner now.

>> LayoutTests/editing/deleting/5206311-2.html:18
>> +<p id="description1">This empties the last row, it should be removed. 'world!' should also be brought into the second cell of the second row</p>
> 
> This isn't really an accurate description, is it?  This test removes the last row but it also removes the 2 rows from the second row.  I would have stated that this test removes cells 5 through 9 so that it's clear what we should get by just looking at the expected result.  When I just see last row should be removed on expected.txt, I can't tell whether it has been removed properly but that what I'm seeing there is still the last row.

I couldn't come up with a short sentence that describes this accurately, so I wrote up descriptions that are a bit more verbose. Let me know what you think.

>> LayoutTests/editing/deleting/5206311-2.html:32
>> +<p id="description2">This empties a the last row of the first table and the first row of the second table. They should both be removed</p>
> 
> Ditto.

Here too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.