[Webkit-unassigned] [Bug 61332] Convert LayoutTests/editing/deleting/5206311-2.html to dump-as-markup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61332





--- Comment #5 from Ryosuke Niwa <rniwa at webkit.org>  2011-05-24 12:37:01 PST ---
(From update of attachment 94531)
View in context: https://bugs.webkit.org/attachment.cgi?id=94531&action=review

>>> LayoutTests/editing/deleting/5206311-2.html:3
>>>  function runTest(num)
>> 
>> I would have modified this function to take an element instead of a number like this.
> 
> Sorry I didn't address this yet. I wasn't sure of a cleaner approach to the problem of grouping all the elements needed for a single test run together (description, root, selection start, selection end). Should I wrap the entire test in a container element, hang classes off the special elements, and query for the correct ones with getElementsByClassName? It would make the code more verbose, but there would be less string concatenation. Let me know what you think.

That would work too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.