[Webkit-unassigned] [Bug 61332] Convert LayoutTests/editing/deleting/5206311-2.html to dump-as-markup

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61332





--- Comment #3 from Annie Sullivan <sullivan at chromium.org>  2011-05-24 12:33:59 PST ---
(From update of attachment 94531)
View in context: https://bugs.webkit.org/attachment.cgi?id=94531&action=review

>> LayoutTests/ChangeLog:7
>> +
> 
> Missing description.

Done.

>> LayoutTests/editing/deleting/5206311-2-expected.txt:2
>> +This empties the last row, it should be removed. 'world!' should also be brought into the second cell of the second row.:
> 
> It's odd to have a period before a colon.

Oops, I didn't notice that Markup.dump() added the colon. I removed the periods from the ends of the descriptions.

>> LayoutTests/editing/deleting/5206311-2-expected.txt:33
>> +This empties a the last row of the first table and the first of the second, they should both be removed.:
> 
> the first row of the second table?  I know you're just converting the existing tests but please revise these descriptions.

Done.

>> LayoutTests/editing/deleting/5206311-2.html:1
>> +<script src="../../resources/dump-as-markup.js"></script>
> 
> Missing DOCTYPE, html, & body.

Done.

>> LayoutTests/editing/deleting/5206311-2.html:3
>>  function runTest(num)
> 
> I would have modified this function to take an element instead of a number like this.

Sorry I didn't address this yet. I wasn't sure of a cleaner approach to the problem of grouping all the elements needed for a single test run together (description, root, selection start, selection end). Should I wrap the entire test in a container element, hang classes off the special elements, and query for the correct ones with getElementsByClassName? It would make the code more verbose, but there would be less string concatenation. Let me know what you think.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.