[Webkit-unassigned] [Bug 61063] TestFailures page shows testers that don't have any failing tests, which isn't useful

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61063


David Kilzer (ddkilzer) <ddkilzer at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94605|review?                     |review+
               Flag|                            |




--- Comment #3 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-05-24 08:02:03 PST ---
(From update of attachment 94605)
View in context: https://bugs.webkit.org/attachment.cgi?id=94605&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:68
> +        getResource(self.buildbot.baseURL + 'json/builders/' + self.name, function(xhr) {

Nit: Seems like "function(xhr) {" should be indented at the same level as the method below.

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:90
> +        },
> +        function(xhr) {
> +            self._cache[cacheKey] = -1;
> +            callback(self._cache[cacheKey]);
> +        });

Nit: Is this code indented correctly?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.