[Webkit-unassigned] [Bug 61000] Control Indexeddb backends from LayoutTestController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61000





--- Comment #16 from Hans Wennborg <hans at chromium.org>  2011-05-24 03:55:30 PST ---
(From update of attachment 94514)
View in context: https://bugs.webkit.org/attachment.cgi?id=94514&action=review


LGTM barring some final nits. Is there a reviewer on the CC list who would like to take a look?

> LayoutTests/ChangeLog:10
> +        from sqlite to leveldb can be tested.

There's no plumbing in the LayoutTests.. this message should probably be in the Source/WebCore/ChangeLog.

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:136
> +    return false;

Add a FIXME that this should be implemented?

> Source/WebCore/storage/IDBLevelDBBackingStore.cpp:1279
> +//    }

Just delete these lines?

> Source/WebCore/storage/IDBSQLiteBackingStore.cpp:996
> +    if (!makeAllDirectories(pathBase)) {

I still don't see any need to create the directory? db.open() will fail if it's not there, right?

> Tools/DumpRenderTree/chromium/LayoutTestController.cpp:1145
> +        m_tempFolder.clear();

i don't think you need the to clear() the OwnPtr before assigning to it.. if it has a non-null value, it will just free that, and take ownership of the new pointer.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.