[Webkit-unassigned] [Bug 32865] [Qt] QWebElement::attribute always returns empty result for input's values

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32865


wolfy <wolfram at ritsuka.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94570|                            |review?, commit-queue?
               Flag|                            |




--- Comment #41 from wolfy <wolfram at ritsuka.org>  2011-05-23 23:09:21 PST ---
Created an attachment (id=94570)
 --> (https://bugs.webkit.org/attachment.cgi?id=94570&action=review)
Patch refined according to last comment

(In reply to comment #39)
> Invalid indentation.
Fixed.

> This is not indented correctly.
Fixed.

> > Source/WebKit/qt/ChangeLog:1
> > +2011-04-29  wolfy  <wolfram at ritsuka.org>
> 
> You should probably put your name in here.
I don't want to do that. 

> This, the title and url, usually goes above the description, not after.
Fixed.

> > Source/WebKit/qt/tests/qwebelement/tst_qwebelement.cpp:1045
> > +    // No initial value
> 
> You should have a period at the end of sentences. (This one and the other comments).
Fixed. But I didn't see periods in any other comments in this file.


> I would think the correct value for inputElement.attribute("value") is empty but not null.
> While a null string would be if there is no value attribute.
> 
> Kind of reverse from the comment for the text, I would expect value to be null in this case, not empty.
Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.