[Webkit-unassigned] [Bug 61252] [Chromium]Add clipping for listBox in popup window to fix wrong location display when the autofill item is really long.

Mon May 23 22:18:29 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=61252

Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94563|review?                     |review-
               Flag|                            |

--- Comment #14 from Kent Tamura <tkent at chromium.org>  2011-05-23 22:18:29 PST ---
(From update of attachment 94563)
View in context: https://bugs.webkit.org/attachment.cgi?id=94563&action=review

> Source/WebCore/manual-tests/autofill-popup-location.html:21
> +      <li> Enter 'This is really long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long long text.' in the following text input area.</li>

Does it mean type the text and then type ENTER to submit the form?

> Source/WebCore/manual-tests/autofill-popup-location.html:23
> +      <li> Enter 'This is short text.' in the following text input area.</li>

ditto.

> Source/WebCore/manual-tests/autofill-popup-location.html:29
> +    <form><input name=p autofocus></form>

This HTML already has an input with autofocus.  Multiple autofocus inputs are confusing.

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:170
> +        , m_maxWindowWidth(INT_MAX)

Because this is a C++ code, we had better use numeric_limits<int>::max() instead of INT_MAX.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.