[Webkit-unassigned] [Bug 61252] [Chromium]Add clipping for listBox in popup window to fix wrong location display when the autofill item is really long.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=61252





--- Comment #11 from Ilya Sherman <isherman at chromium.org>  2011-05-23 22:10:54 PST ---
(From update of attachment 94561)
View in context: https://bugs.webkit.org/attachment.cgi?id=94561&action=review

I am not a WebKit reviewer, but this looks good to me.

> Source/WebCore/ChangeLog:11
> +        * manual-tests/autofill-popup-location.html: With long ong text, test the shown location is correct.

nit: Please remove "ong"

> Source/WebCore/platform/chromium/PopupMenuChromium.cpp:364
> +        // When clipping, we have to set and notify listBox() the change.

nit: This comment might be clearer as """When clipping, we also need to set a maximum width for the list box."""

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.